-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add staging metadata for matterverse.ai #83
Conversation
Co-authored-by: Ji Qi <JiQi535@users.noreply.github.com> Co-authored-by: Christen Xie <christen03@users.noreply.github.com>
"type": "links", | ||
"attributes": { | ||
"name": "Matterverse", | ||
"description": "Database of 31 million hypothetical materials generated through advanced machine learning algorithms", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would not add the number ("31 million") as it may change in the future and may become out-of-sync. Maybe change to "over 31 million"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point, thanks for pointing it out. you're right - over 31 million is definitely better!
"attributes": { | ||
"name": "OPTIMADE Providers Index Meta-Database", | ||
"description": "The list of OPTIMADE providers maintained by Materials-Consortia", | ||
"base_url": "https://providers.optimade.org", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"base_url": "https://providers.optimade.org", | |
"base_url": "matterverse.ai/optimade", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base_url
has to be an URL, thus either http://
or https://
will be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also not the base_url
that you want to change, this is mean to be an additional link back to the providers list. The one you want to change is currently null
(I'll tag you in a comment at the correct line)
"attributes": { | ||
"name": "Matterverse", | ||
"description": "Database of 31 million hypothetical materials generated through advanced machine learning algorithms", | ||
"base_url": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christen03 this is the one!
Co-authored-by: Christen <99223047+christen03@users.noreply.github.com>
Superseded by #101 |
Add placeholder for https://matterverse.ai, an in progress OPTIMADE API.
@JiQi535 @christen03