Re-enable aggregation on JARVIS #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks legit, but why the OPTIMADE validator is failing? |
ml-evs
commented
Dec 22, 2023
merkys
approved these changes
Dec 22, 2023
ml-evs
force-pushed
the
ml-evs/jarvis
branch
from
e2337bd
to
c62bfee
Compare
|
I'll actually hold off merging here until @knc6 confirms it is ready |
|
@ml-evs IMO its ready, please go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes #79 and enables query aggregation on JARVIS again. Need to verify first with @knc6 that filters and pagination are working again.