fixes required for deeper pymathics modules #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatera
commented
Apr 7, 2024
mathics/doc/gather.py
Outdated
| # | ||
| visited = set() | ||
| for symbol_instance in builtins_by_module[module.__name__]: | ||
| for symbol_instance in builtins_by_module.get(module.__name__,[]): |
Contributor
Author
There was a problem hiding this comment.
Actually, the main change in this file is this line. To move the other functions is just to improve the organization of the code.
Contributor
Author
|
This is how the documentation looks with the current changes:
Of course, the docstrings for the guides must be completed. |
Member
|
I am okay with this, although as you say, functionally there is no difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seems to fix the issue with Pymathics Natlang documentation (Mathics3/Mathics3-Module-nltk#19 (comment))