-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundling and pkg fixes #26
Merged
Merged
Commits on Oct 17, 2023
-
feat: integrating testnet 6 version of polykey
* fixed parser imports to take it from the domain utilities, also exported the validate functions * all using `binParsers` now
Configuration menu - View commit details
-
Copy full SHA for f8849e1 - Browse repository at this point
Copy the full SHA f8849e1View commit details -
* `esbuild` bundle is used for application build * changed to using `buildNpmPackage` instead of `node2nix` * changed to using `@yao-pkg/pkg` instead of `pkg` to use v18.15 nodejs
Configuration menu - View commit details
-
Copy full SHA for 2ef4aa9 - Browse repository at this point
Copy the full SHA 2ef4aa9View commit details -
fix:
node.id
has been updated tonode.nodeId
within `src/identiti……es/CommandList.ts`
Configuration menu - View commit details
-
Copy full SHA for dd5fb99 - Browse repository at this point
Copy the full SHA dd5fb99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60a20d5 - Browse repository at this point
Copy the full SHA 60a20d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12a69f7 - Browse repository at this point
Copy the full SHA 12a69f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28cb2c7 - Browse repository at this point
Copy the full SHA 28cb2c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaedd66 - Browse repository at this point
Copy the full SHA eaedd66View commit details -
fix: adding
threads
tooptionalDependencies
This makes sure the `esbuild` treats `threads` as an external dependency. There is some monkey patching going on that doesn't work if it's bundled.
Configuration menu - View commit details
-
Copy full SHA for ce65d52 - Browse repository at this point
Copy the full SHA ce65d52View commit details -
Configuration menu - View commit details
-
Copy full SHA for c73d87f - Browse repository at this point
Copy the full SHA c73d87fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6dbea - Browse repository at this point
Copy the full SHA 7f6dbeaView commit details -
fix: fixed keys renew and reset tests
It's a race condition with propagating keys changes. We needed to wait and then attempt calls with the new nodeId. I think there's a separate issue when verifying with the old nodeId. That needs to be checked inside `Polykey` though.
Configuration menu - View commit details
-
Copy full SHA for 331b9f8 - Browse repository at this point
Copy the full SHA 331b9f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee1de51 - Browse repository at this point
Copy the full SHA ee1de51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.