Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cf cache header changes for versioned assets. #108

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Add cf cache header changes for versioned assets. #108

merged 1 commit into from
Sep 21, 2024

Conversation

shafiqihtsham
Copy link
Contributor

@shafiqihtsham shafiqihtsham commented Sep 19, 2024 •
edited
Loading

Description

This PR is to address partial caching issues docusaurus sites can face when attempting to fetch the latest resources.

Issues Fixed

  • Fixes #...

Tasks

  • 1.Update env.example
  • 2. Update worker.ts to apply headers to requests.
  • 3. Add environment variable key to CI.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

CMCDragonkai
CMCDragonkai reviewed Sep 19, 2024
View reviewed changes
server/worker.ts Outdated Show resolved Hide resolved
@CMCDragonkai
Copy link
Member

I also added the POLYKEY_DOCS_ENV to the repository secrets.

@shafiqihtsham
feat: add cache changes for versioned assets
fb3ccd3 
fix: add back /docs redirect

fix: lint
@shafiqihtsham shafiqihtsham merged commit 929ffcc into staging Sep 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMCDragonkai CMCDragonkai CMCDragonkai left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shafiqihtsham @CMCDragonkai