Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polykey integration into workflow #110

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

brynblack
Copy link
Member

Description

This PR integrates pk secrets env into the development shell. It also fixes an API issue regarding secrets used to authenticate with Cloudflare's API. It replaces the AUTH_... secrets with an API token.

Tasks

  • 1. Replace . ./.env with pk secrets env ...
  • 2. Fix API security issue

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@brynblack brynblack self-assigned this Oct 11, 2024
@brynblack brynblack merged commit 213051d into staging Oct 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant