ci: merge staging to master

[MatrixAI-Bot]

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

[MatrixAI-Bot]

Pipeline Attempt on 585509433 for ceaebe6

https://gitlab.com/MatrixAI/open-source/js-polykey/-/pipelines/585509433

[CMCDragonkai]

@emmacasolin if any intermittent test failures occur here, it's best to be solved by solving the underlying problem, not just making fixes here in this branch.

That will be all the new issues that were created and some of the PRs that @tegefaulkes created.

• Seed Nodes Restart after 1 hr due to ErrorNodeGraphEmptyDatabase #398
• WorkerManager is being reported to be created **after** the agent is already started and reported its status #399
• Packaged executable integration tests - initial integration tests with docker #391
• Fix Failing Build Tests on Windows & MacOS Polykey-CLI#14
• Integration tests for docker image #407
• Integration Tests for Windows Polykey-CLI#11
• Integration Tests for MacOS Polykey-CLI#12

You can also help @tegefaulkes flesh out those issues too.

[MatrixAI-Bot]

Pipeline Attempt on 586532953 for 0894eab

https://gitlab.com/MatrixAI/open-source/js-polykey/-/pipelines/586532953

[MatrixAI-Bot]

Pipeline Attempt on 586804088 for 2b79b48

https://gitlab.com/MatrixAI/open-source/js-polykey/-/pipelines/586804088

[MatrixAI-Bot]

Pipeline Attempt on 588459726 for 37f03d9

https://gitlab.com/MatrixAI/open-source/js-polykey/-/pipelines/588459726

[CMCDragonkai]

Is there a way to also disable the CI when we have a wip or WIP as the prefix to the commit message?

[CMCDragonkai]

The this.basePath used in side NodeManager should just use this.constructor.name.

And all public properties should be up top of the class. Try to give some spacing between the arrow function properties though especially since they are going to have docblocks subsequently.

[tegefaulkes]

The scratch is passing.

INFO:NodeManager test:checking names
INFO:NodeManager test:NodeManager.refreshBucketHandler
INFO:NodeManager test:NodeManager.gcBucketHandler
INFO:NodeManager test:NodeManager.pingAndSetNodeHandler
INFO:NodeManager test:end of names

https://gitlab.com/MatrixAI/open-source/Polykey/-/jobs/3081733042

[tegefaulkes]

BUT it's failing in the nodes domain.

  ● NodeManager test › Should have unique HandlerIds
    expect(received).not.toEqual(expected) // deep equality
    Expected: not "NodeManager."
      1052 |       logger,
      1053 |     });
    > 1054 |     expect(nodeManager.gcBucketHandlerId).not.toEqual(
           |                                               ^
      1055 |       nodeManager.refreshBucketHandlerId,
      1056 |     );
      1057 |     expect(nodeManager.gcBucketHandlerId).not.toEqual(
      at Object.<anonymous> (tests/nodes/NodeManager.test.ts:1054:47)

[CMCDragonkai]

Ok investigating that later, move to the docker stuff.

It's interesting that basically the constructor name is fine, but the arrow function property name is not.

[MatrixAI-Bot]

Pipeline Attempt on 650341300 for 724fd12

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650341300

[tegefaulkes]

The Docker integration tests should be passing now. it will take a while for the CI to confirm this.

[MatrixAI-Bot]

Pipeline Attempt on 650368198 for 9a58452

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650368198

[MatrixAI-Bot]

Pipeline Attempt on 650409110 for ec5aa57

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650409110

[MatrixAI-Bot]

Pipeline Attempt on 650466358 for c918000

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650466358

[MatrixAI-Bot]

Pipeline Succeeded on 650466358 for c918000

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650466358

[CMCDragonkai]

Avoid wip commits on staging, one it is on staging, we generally don't squash history. We just roll forward.

[MatrixAI-Bot]

Pipeline Attempt on 650511030 for de75773

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650511030

[CMCDragonkai]

To finish up 5. #411 (comment) we need to do a prerelease tag to observe the GH release page.

Remember the steps are:

npm version prerelease --preid alpha
git push --follow-tags

[CMCDragonkai]

To finish 4. #411 (comment), make sure to only disable the discovery tests. Apparently you don't need to disable the tests/nat?

[CMCDragonkai]

It looks like swc-jest is choking on decorator syntax: https://gitlab.com/MatrixAI/open-source/Polykey/-/jobs/3083242775

  ● Test suite failed to run
      x Unexpected token `@`. Expected this, import, async, function, [ for array literal, { for object literal, @ for decorator, function, class, null, true, false, number, bigint, string, regexp, `
      | for template literal, (, or an identifier
        ,-[/builds/MatrixAI/open-source/Polykey/src/acl/ACL.ts:22:1]
     22 | @CreateDestroyStartStop(
        : ^
        `----

[CMCDragonkai]

Ok I think I remember what the problem was.

1. ts-node uses swc, and properly fulfills the swc config
2. swc by itself does not respect tsconfig.json
3. which means swc needs its own configuration

Need to create something like this https://swc.rs/docs/configuration/swcrc

Map it from our current tsconfig.json. We could do this dynamically inside jest.config.js by putting it into the config parameter:

const fs = require('fs')

const config = JSON.parse(fs.readFileSync(`${__dirname}/.swcrc`, 'utf-8'))

module.exports = {
  transform: {
    '^.+\\.(t|j)sx?$': ['@swc/jest', { ...config, /* custom configuration in Jest */ }],
  },
}

[CMCDragonkai]

@tegefaulkes please create an issue for the arrow function property names that occurred in the NodeManager.

Also can you keep track of all the tests that been disabled, this should be done in #441.

[MatrixAI-Bot]

Pipeline Succeeded on 650511030 for de75773

https://gitlab.com/MatrixAI/open-source/Polykey/-/pipelines/650511030

[CMCDragonkai]

Ok this PR closed, all the remaining comments above, we will do on the next staging commits.