Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding better error messaging when stringifying errors in logging #828

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Adding better error messaging when stringifying errors in logging #828

merged 3 commits into from
Oct 15, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Oct 15, 2024 •
edited
Loading

Description

This PR cleans up some error messaging in hope that it will make further error logging more clear for debug.

Issues Fixed

Tasks

  • 1. Add better description and include cause details when stringifying errors.
  • 2. Add descriptions to all usage of utils.never().
  • 3. Add a better error to send notification when sending is rejected by peer for lack of trust.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Oct 15, 2024
@linear Linear
Copy link

linear bot commented Oct 15, 2024

ENG-427 Vault sharing notification is not sent

@tegefaulkes tegefaulkes merged commit f40659a into staging Oct 15, 2024
36 checks passed
@tegefaulkes tegefaulkes mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tegefaulkes