Merged
Conversation
Member
code-crusher
commented
Mar 18, 2026
- feat: add fade-up and shimmer animations to ChatRow, ChatView, and ReasoningBlock (feat: add fade-up and shimmer animations to ChatRow, ChatView, and ReasoningBlock #65)
- improve reasoning flow + time tracking (release/v5.6.2 #66)
- release/v5.6.3 (release/v5.6.3 #67)
- release/v5.6.4 (release/v5.6.4 #68)
- release/v5.6.5 (release/v5.6.5 #69)
- update git repo URL (release/v5.6.6 #70)
- name cleanup
Contributor
Contributor
There was a problem hiding this comment.
🧪 PR Review is completed: Reviewed the version bump and CSS shimmer animation updates. Found a logical error in the CSS gradient stops that will break the intended visual effect.
Skipped files
webview-ui/src/i18n/locales/en/kilocode.json: Skipped file pattern
| var(--vscode-foreground) 0%, | ||
| var(--vscode-foreground) 40%, | ||
| color-mix(in srgb, var(--vscode-foreground) 55%, transparent) 50%, | ||
| color-mix(in srgb, var(--vscode-foreground) 70%, transparent) 10%, |
Contributor
There was a problem hiding this comment.
🟠 CSS Logic
Issue: The color stop percentage 10% is out of order in the linear gradient (it comes after 40% and before 60%). In CSS, out-of-order color stops are automatically clamped to the largest preceding position (so it will be treated as 40%), which likely breaks the intended visual shimmer effect.
Fix: Change the percentage to 50% to properly center the shimmer highlight between 40% and 60%.
Impact: Ensures the shimmer animation renders correctly as intended.
Suggested change
| color-mix(in srgb, var(--vscode-foreground) 70%, transparent) 10%, | |
| color-mix(in srgb, var(--vscode-foreground) 70%, transparent) 50%, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.