Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.rst in "The YAML interface" #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaidevPolisetty
Copy link

Added definition for high allocation and low utilisation

Added definition for high allocation and low utilisation
@maxfischer2781 maxfischer2781 self-assigned this Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (13adaf9) to head (4154857).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          33       33           
  Lines        1108     1108           
  Branches      206      206           
=======================================
  Hits         1027     1027           
  Misses         59       59           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, but I don't see how that content fits in this location.

This section is on the general config/pipeline structure. The !LinearController and !CpuPool are just examples here, so documenting their parameters is at best a tangent and unrelated to the intended scope. In addition, the wording used isn't appropriate for COBaLD: drones and draining is a concept exclusive to TARDIS.

If you can find a more suitable location and more generic wording, this could fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants