Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change readthedocs python version #310

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Aug 11, 2023

readthedocs is using Python3.7 to build the documentation by default, which now failing since we require a minium python version of 3.8. This pull request fixes the failing readthedocs build by requesting a build using Python 3.11.

In addition, the build seem to fail with sphinx==7, so that we now require sphinx<7 in setup.py. See readthedocs/readthedocs.org#10279 for details.

In addition, the rendering of the two column layout seems to have problems with newer version of docutils. Therefore, we will fix docutils<0.17 for the time being. Thanks to @mschnepf for the report.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa30b0c) 98.90% compared to head (daecc93) 98.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          55       55           
  Lines        2277     2277           
=======================================
  Hits         2252     2252           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giffels giffels marked this pull request as ready for review August 11, 2023 16:50
@giffels giffels requested review from rfvc and RHofsaess August 11, 2023 16:50
@giffels giffels self-assigned this Aug 11, 2023
@giffels giffels added the bug Something isn't working label Aug 11, 2023
RHofsaess
RHofsaess previously approved these changes Aug 11, 2023
rfvc
rfvc previously approved these changes Aug 14, 2023
@giffels giffels dismissed stale reviews from rfvc and RHofsaess via daecc93 August 14, 2023 09:06
@giffels giffels requested review from rfvc and RHofsaess August 14, 2023 09:07
@giffels
Copy link
Member Author

giffels commented Aug 14, 2023

@rfvc @RHofsaess could you review again, please? By fixing docutils<0.17 also sphinx==5.3.0 is installed, so that I removed that constraint.

@giffels giffels added this pull request to the merge queue Aug 15, 2023
Merged via the queue into MatterMiners:master with commit 24cdb48 Aug 15, 2023
32 checks passed
@giffels giffels deleted the fix-readthedocs-build branch August 15, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants