gh-417 Clear selection when adding to a data spec or after 24h #443
Conversation
…nd also after 24 hours in any case
NigelPalmer
force-pushed
the
feature/gh-417-element-selection-too-persistent
branch
from
65a23e5
to
17fb838
Compare
| @@ -42,6 +39,7 @@ <h3>Current selection</h3> | |||
| <mdm-data-element-multi-select | |||
| [sourceTargetIntersections]="sourceTargetIntersections" | |||
| [dataElements]="(selectedElements$ | async) ?? []" | |||
| (selectionAddedToSpec)="clearSelection()" | |||
There was a problem hiding this comment.
mdm-data-element-multi-select is used in other parts of the code and the (selectionAddedToSpec) has not been added to these definitions which means the selection IS NOT cleared when using those parts. E.g, this one does not clear the spec list after being clicked.
Extra Task: The dialog in the screenshot above also does not disappear after the spec has been updated, even if the user clicks on "Open Data Specification" after the fields have been added. Could we please fix this whilst we are working in this area.
There was a problem hiding this comment.
Added the clearSelection trigger here, but not on bookmarks page, since that selection is not persistent anyway and user may find it helpful to add a small set of fields to multiple specs (not now possible from the main browse)
Extra Task seems to have resolved itself by virtual of clearing the selection
… also clears selection
There was a problem hiding this comment.
Unfortunately I have found another problem. If I log in as researcher_one and select some items, logout and login as manager_one then those items are still selected. I know it is a lot less common for people to share a computer these days, but this still does not feel correct. It creates the impression that users can view other users data.
|
As discussed, use of localStorage can remain as-is for now, pending a larger review of its use in these UIs |
NigelPalmer
deleted the
feature/gh-417-element-selection-too-persistent
branch
As discussed with Nigel, doesn't quite match the ticket but this approach should strike a good balance of convenience and avoiding confusion.
Closes #417