Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header row in CSV file #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lockedmouse
Copy link
Contributor

As of the current release, there is no more line break between the header and the actual data in the csv file, aka it looks like this:

millis,pressure,avg_pressure,arousal,motor_speed,sensitivity_threshold,clench_pressure_threshold,clench_duration15,0,0,0,300,2755,0,1
68,0,0,0,300,2755,0,1

when it should look like this:

millis,pressure,avg_pressure,arousal,motor_speed,sensitivity_threshold,clench_pressure_threshold,clench_duration
15,0,0,0,300,2755,0,1
68,0,0,0,300,2755,0,1

This definitely worked in v0.6.4, so it must be a regression introduced by one of the later patches.

No idea if my commit is the correct solution, feel free to fix it some other way if needed.

@lockedmouse
Copy link
Contributor Author

lockedmouse commented Jan 23, 2025

Also, it looks like the header row is outdated: The pressure field is no longer written, and instead there is a new orgasm_count field at the end.

Any specific reason why pressure is no longer written to the CSV file?

Also, the avg_pressure field is always written as 0, when it was working in the past. So I think the logging is broken.

Edit: I see this was already reported in #95. My PR fixes the header row but none of the other bugs.

@lockedmouse lockedmouse changed the title Add missing line break after header row in csv file Fix header row in CSV file Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant