Make it possible to use Py_Finalize before calling the PythonQt destructor#267
Closed
MinyazevR wants to merge 5 commits intoMeVisLab:mainfrom
MinyazevR:MinyazevR-fix-tests
Closed
Make it possible to use Py_Finalize before calling the PythonQt destructor#267MinyazevR wants to merge 5 commits intoMeVisLab:mainfrom MinyazevR:MinyazevR-fix-tests
MinyazevR wants to merge 5 commits intoMeVisLab:mainfrom
MinyazevR:MinyazevR-fix-tests
Conversation
MinyazevR
changed the title
Contributor
|
@MinyazevR, please, rebase and review this PR. Seems like some of proposed fixes are already merged. It would be useful to understand, what fixes we do expect to be upstream-ed to reduce the diff between our fork and the upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namely, adding
PythonQt::preCleanUp, which is called beforePy_FinalzeExand clears some fields, which makes it possible to callPythonQt::Cleanupwithout subsequent crashes.Python3.12.0-3.12.4due to issue.3 Small changes to improve c++ code.