Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- patch로 변경
- parentId없이 name, slug를 수정 하면 발생하는 문제 해결 - artwork, slug가 null일때 발생하는 문제 해결 - parentId로 자기자신을 호출할때 발생하는 문제 해결
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
- checkDeath()를 나중에 호출하도록 했습니다.
Hoon9901
requested changes
May 10, 2024
src/main/java/com/example/codebase/domain/magazine/service/MagazineCategoryService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/codebase/domain/magazine/service/MagazineCategoryService.java
Show resolved
Hide resolved
src/main/java/com/example/codebase/domain/magazine/service/MagazineCategoryService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/codebase/domain/magazine/service/MagazineCategoryService.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix #165 +/- ##
=========================================
Coverage ? 72.14%
Complexity ? 1726
=========================================
Files ? 254
Lines ? 6384
Branches ? 295
=========================================
Hits ? 4606
Misses ? 1573
Partials ? 205
Continue to review full report in Codecov by Sentry.
|
Hoon9901
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
artwork, parentId, slud 가 null일 경우에 발생하던 400에러를 해결하였습니다.
parentId로 자기 지신의 id를 집어넣을시 발생하던 stackoverflow문제를 해결했습니다.
카테고리 수정시 api가 put에서 patch로 변경되었습니다.
🦾 연관된 이슈
jirra이슈