Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #167

Merged
merged 11 commits into from
May 10, 2024
Merged

Main #167

merged 11 commits into from
May 10, 2024

Conversation

Hoon9901
Copy link
Contributor

๐Ÿ“ ์ž‘์—… ๋‚ด์šฉ

์ด๋ฒˆ PR์—์„œ ์ž‘์—…ํ•œ ๋‚ด์šฉ์„ ๊ฐ„๋‹จํ•˜๊ฒŒ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

๊ณ ๋ฏผํ•œ ๋‚ด์šฉ์ด๋‚˜, ๋ฌธ์ œ๋ฅผ ์–ด๋–ป๊ฒŒ ํ•ด๊ฒฐํ–ˆ๋Š”์ง€ ์ž‘์„ฑํ•ด์ฃผ๋Š”๊ฒƒ๋„ ์ข‹์Šต๋‹ˆ๋‹ค.

์ด๋ฏธ์ง€ ์ฒจ๋ถ€ํ•˜๋ฉด ๋” ์ข‹์•„์š”

๐Ÿฆพ ์—ฐ๊ด€๋œ ์ด์Šˆ

ex) JIRA๋งํฌ, #์ด์Šˆ๋ฒˆํ˜ธ

๐Ÿ’ฌ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ

๋ฆฌ๋ทฐ์–ด๊ฐ€ ํŠน๋ณ„ํžˆ ๋ด์ฃผ์—ˆ์œผ๋ฉด ํ•˜๋Š” ๋ถ€๋ถ„์ด ์žˆ๋‹ค๋ฉด ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”

ex) ๋ฉ”์„œ๋“œ XXX์˜ ์ด๋ฆ„์„ ๋” ์ž˜ ์ง“๊ณ  ์‹ถ์€๋ฐ ํ˜น์‹œ ์ข‹์€ ๋ช…์นญ์ด ์žˆ์„๊นŒ์š”?

haroya01 and others added 11 commits May 10, 2024 09:57
- parentId์—†์ด name, slug๋ฅผ ์ˆ˜์ • ํ•˜๋ฉด ๋ฐœ์ƒํ•˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ
- artwork, slug๊ฐ€ null์ผ๋•Œ ๋ฐœ์ƒํ•˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ
- parentId๋กœ ์ž๊ธฐ์ž์‹ ์„ ํ˜ธ์ถœํ• ๋•Œ ๋ฐœ์ƒํ•˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ
- checkDeath()๋ฅผ ๋‚˜์ค‘์— ํ˜ธ์ถœํ•˜๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.
fix : ์นดํ…Œ๊ณ ๋ฆฌ ์ˆ˜์ • ๋ฌธ์ œ ํ•ด๊ฒฐ
@Hoon9901 Hoon9901 merged commit a0393c7 into develop May 10, 2024
4 checks passed
Copy link

Qodana Community for JVM

It seems all right ๐Ÿ‘Œ

No new problems were found according to the checks applied

๐Ÿ’ก Qodana analysis was run in the pull request mode: only the changed files were checked
โ˜๏ธ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants