Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] 매거진 수정시 categorySlug가 null을 허용하도록 변경 #169

Merged
merged 4 commits into from
May 15, 2024

Conversation

haroya01
Copy link
Collaborator

📝 작업 내용

매거진 수정시 MagazineRequest.Update에서 categorySlug가 null일경우 기존의 slug를 반영하도록 수정했습니다.
추후에 확장과 변경이 용이하도록 더 나은 magazineCategory를 조회 및 magazine에서 category를 수정하는 로직에 대해서 고민해보겠습니다.

🦾 연관된 이슈

jirra이슈

💬리뷰 요구사항

@haroya01 haroya01 added the bug Something isn't working label May 15, 2024
@haroya01 haroya01 requested a review from Hoon9901 May 15, 2024 10:30
@haroya01 haroya01 self-assigned this May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (f71bf03) to head (b161625).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #169      +/-   ##
=============================================
- Coverage      72.15%   72.14%   -0.01%     
- Complexity      1728     1729       +1     
=============================================
  Files            254      254              
  Lines           6389     6394       +5     
  Branches         296      296              
=============================================
+ Hits            4610     4613       +3     
- Misses          1574     1576       +2     
  Partials         205      205              
Files Coverage Δ
...xample/codebase/controller/MagazineController.java 91.07% <100.00%> (-0.16%) ⬇️
.../codebase/domain/magazine/dto/MagazineRequest.java 84.78% <ø> (ø)
...ebase/domain/magazine/service/MagazineService.java 91.89% <100.00%> (+0.71%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0715a...b161625. Read the comment docs.

@haroya01 haroya01 merged commit d20d988 into develop May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants