Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 직책 변경시 자기 자신이 변경되던 문제 해결 #170

Conversation

haroya01
Copy link
Collaborator

📝 작업 내용

  • 팀 유저 직책 변경 api - > patch : team-users/{username} api 문제해결

직책 변경시 자기 자신이 변경되는 문제를 해결했습니다.

image

🦾 연관된 이슈

jirra이슈

💬리뷰 요구사항

@haroya01 haroya01 added the bug Something isn't working label May 15, 2024
@haroya01 haroya01 requested a review from Hoon9901 May 15, 2024 10:33
@haroya01 haroya01 self-assigned this May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (ef9e0c5) to head (8adac29).
Report is 7 commits behind head on develop.

❗ Current head 8adac29 differs from pull request most recent head 258dc3e. Consider uploading reports for the commit 258dc3e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #170      +/-   ##
=============================================
- Coverage      72.18%   72.14%   -0.04%     
- Complexity      1725     1729       +4     
=============================================
  Files            255      254       -1     
  Lines           6370     6394      +24     
  Branches         291      296       +5     
=============================================
+ Hits            4598     4613      +15     
- Misses          1570     1576       +6     
- Partials         202      205       +3     
Files Coverage Δ
.../codebase/domain/team/service/TeamUserService.java 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9dcd89...258dc3e. Read the comment docs.

@Hoon9901 Hoon9901 merged commit 8671f9c into develop May 15, 2024
3 checks passed
@Hoon9901 Hoon9901 deleted the ART-189-be-팀-유저-정보-변경시-자신이-변경되는-문제-해결 branch May 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants