Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] 내 프로필 이미지 변경 시 url 받도록 변경 #171

Conversation

Hoon9901
Copy link
Contributor

📝 작업 내용

S3 업로드가 아닌 URL을 받도록 멤버 프로필 이미지 변경 API 수정

🦾 연관된 이슈

https://mediaxi.atlassian.net/browse/ART-190

💬리뷰 요구사항

@Hoon9901 Hoon9901 requested a review from haroya01 May 15, 2024 10:51
@Hoon9901 Hoon9901 self-assigned this May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.18%. Comparing base (b161625) to head (ef9e0c5).
Report is 1 commits behind head on develop.

❗ Current head ef9e0c5 differs from pull request most recent head 26e0507. Consider uploading reports for the commit 26e0507 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #171      +/-   ##
=============================================
+ Coverage      72.14%   72.18%   +0.03%     
+ Complexity      1729     1725       -4     
=============================================
  Files            254      255       +1     
  Lines           6394     6370      -24     
  Branches         296      291       -5     
=============================================
- Hits            4613     4598      -15     
+ Misses          1576     1570       -6     
+ Partials         205      202       -3     
Files Coverage Δ
.../example/codebase/controller/MemberController.java 70.12% <100.00%> (-1.83%) ⬇️
...mple/codebase/domain/member/dto/ProfileUrlDTO.java 100.00% <100.00%> (ø)
.../example/codebase/domain/member/entity/Member.java 63.12% <ø> (-0.63%) ⬇️
.../codebase/domain/member/service/MemberService.java 65.06% <100.00%> (+3.62%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20d988...26e0507. Read the comment docs.

Copy link
Collaborator

@haroya01 haroya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ^^!

@Hoon9901 Hoon9901 merged commit d9dcd89 into develop May 15, 2024
2 of 3 checks passed
@Hoon9901 Hoon9901 deleted the ART-190-be-내-프로필-이미지-변경-시-url-받도록-변경 branch May 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants