Skip to content

Commit

Permalink
Merge branch 'fix/sdk-0.30.0' into feat/sdk-0.31.0
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Aug 9, 2023
2 parents 814e09d + f2087c2 commit 905bee2
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tap_snowflake/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from singer_sdk.helpers._batch import BaseBatchFileEncoding, BatchConfig
from singer_sdk.streams.core import REPLICATION_FULL_TABLE, REPLICATION_INCREMENTAL
from snowflake.sqlalchemy import URL
from sqlalchemy.engine import Engine
from sqlalchemy.sql import text


Expand Down Expand Up @@ -69,7 +68,12 @@ def get_sqlalchemy_url(cls, config: dict) -> str:

return URL(**params)

def create_engine(self) -> Engine:
def create_engine(self) -> sqlalchemy.engine.Engine:
"""Create SQLAlchemy engine instance.
Returns:
A SQLAlchemy engine.
"""
return sqlalchemy.create_engine(
self.sqlalchemy_url,
echo=False,
Expand Down

0 comments on commit 905bee2

Please sign in to comment.