Fixed stupid bug where I was printing null instead of the expected va…

…lue.
MeltyPlayer · Oct 21, 2024 · 049a234 · 049a234
1 parent 6b0a33f
commit 049a234
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 1 deletion.
diff --git a/Schema Tests/binary/generator/RAtPositionGeneratorTests.cs b/Schema Tests/binary/generator/RAtPositionGeneratorTests.cs
@@ -254,6 +254,54 @@ public void Write(IBinaryWriter bw) {
 ");
   }
 
+  [Test]
+  public void TestArrayUntilEndOfStreamAtOffset() {
+    BinarySchemaTestUtil.AssertGenerated(@"
+using schema.binary;
+using schema.binary.attributes;
+
+namespace foo.bar {
+  [BinarySchema]
+  public partial class OffsetWrapper : IBinaryConvertible {
+    public uint Offset { get; set; }
+
+    [RAtPosition(nameof(Offset))]
+    [RSequenceUntilEndOfStream]
+    public byte[] EndOfStreamArray { get; set; }
+  }
+}",
+                                         @"using System;
+using System.Collections.Generic;
+using schema.binary;
+
+namespace foo.bar {
+  public partial class OffsetWrapper {
+    public void Read(IBinaryReader br) {
+      this.Offset = br.ReadUInt32();
+      {
+        var tempLocation = br.Position;
+        br.Position = this.Offset;
+        this.EndOfStreamArray = br.ReadBytes(br.Length - br.Position);
+        br.Position = tempLocation;
+      }
+    }
+  }
+}
+",
+                                         @"using System;
+using schema.binary;
+
+namespace foo.bar {
+  public partial class OffsetWrapper {
+    public void Write(IBinaryWriter bw) {
+      bw.WriteUInt32(this.Offset);
+      bw.WriteBytes(this.EndOfStreamArray);
+    }
+  }
+}
+");
+  }
+
   [Test]
   public void TestOffsetFromParent() {
     BinarySchemaTestUtil.AssertGenerated(@"

diff --git a/Schema/src/binary/text/BinarySchemaReaderGenerator.cs b/Schema/src/binary/text/BinarySchemaReaderGenerator.cs
@@ -522,7 +522,6 @@ private static void ReadArray_(
       HandleAtPosition_(
           sw,
           member,
-          "null",
           _ => {
             var qualifiedElementName
                 = sourceSymbol.GetQualifiedNameFromCurrentSymbol(