Fix memory leak bug #4
Conversation
|
Should this target the |
|
our current nixpkgs overlay setup on hs-opentelemetry-* is pretty messy right now. we are not using hs-opentelemetry-* from a single commit and for this package, we were actually using hackage 0.0.3.6 version, not from git source. so I first made this on top of 0.0.3.6. (otherwise, the build failed in other places). So refer to this for showing diff. I will make a direct patch for our build and for the upstream of hs-opentelemetry, I will make a PR again. Thanks. |
|
I was able to build it on top of |
| @@ -97,7 +100,7 @@ addAttribute AttributeLimits{..} Attributes{..} k v = case attributeCountLimit o | |||
|
|
|||
| addAttributes :: ToAttribute a => AttributeLimits -> Attributes -> [(Text, a)] -> Attributes | |||
| -- TODO, this could be done more efficiently | |||
| addAttributes limits = foldl (\attrs' (k, v) -> addAttribute limits attrs' k v) | |||
| addAttributes limits = foldl' (\(!attrs') (!k, !v) -> addAttribute limits attrs' k v) | |||
There was a problem hiding this comment.
The bang on attrs' is redundant because we're using foldl':
| addAttributes limits = foldl' (\(!attrs') (!k, !v) -> addAttribute limits attrs' k v) | |
| addAttributes limits = foldl' (\attrs' (!k, !v) -> addAttribute limits attrs' k v) |
| @@ -394,7 +394,7 @@ addAttribute :: (MonadIO m, A.ToAttribute a) | |||
| -> a | |||
| -- ^ Attribute value | |||
| -> m () | |||
| addAttribute (Span s) k v = liftIO $ modifyIORef s $ \i -> i | |||
| addAttribute (Span s) k v = liftIO $ modifyIORef' s $ \i -> i `seq` i | |||
There was a problem hiding this comment.
This seq is redundant because i comes from the IORef, and now that we use modifyIORef', it is already evaluated.
| addAttribute (Span s) k v = liftIO $ modifyIORef' s $ \i -> i `seq` i | |
| addAttribute (Span s) k v = liftIO $ modifyIORef' s $ \i -> i |
The other seq in this file are also redundant.
a few strictness annotation and using proper strict functions makes memory leak go away.