Fix applying changeset to DB with constraints on SQLite (fixes #210) #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the issues checked by this function are now handled.
Co-authored-by: David Koňařík <dvdkon@konarici.cz>
dvdkon
force-pushed
the
constraint-conflicts
branch
from
e17153e to
63efe50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #210 (applying patches to databases with constraints can fail) for SQLite by retrying the application of conflicting changeset entries until all are applied or the process stalls.
This is a somewhat ugly method, but SQLite doesn't let us defer
FOREIGN KEYconstraints and attempting to fully serialise our changes would be a lot more effort.I plan on sending a PR fixing this for PostgreSQL later.