Record edit conflict when UPDATE is rebased on top of DELETE#250
Open
Record edit conflict when UPDATE is rebased on top of DELETE#250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebasing a changeset where our side updates a row that the other side has deleted, the delete wins and the update is discarded. Previously this was done silently with no record in the conflict file.
This change records the discarded update as a conflict entry, so callers can inspect what data was lost. Each column that our update was changing gets a conflict item with the original (base) value and our intended new value. The
oldkey is absent since the other side deleted the row rather than setting new column values.Fixes #248