Conversation
…dation script. Also updates NewWallet table in db after validation
… description logic
…ion-wallet-import-api
… summary
- Changed signer descriptions to a sequential format ("Signer 1", "Signer 2", etc.) for clarity.
- Added support for `signersDRepKeys`, `stakeCredentialHash`, and `scriptType` in the multisig import summary.
- Updated the API response to include a generated invite URL for the multisig wallet.
…ion-wallet-import-api get latest updates
- Added paymentCbor field to NewWallet model in schema.prisma. - Updated the ejection redirect API to handle paymentCbor during wallet creation and updates. - Enhanced multisig import validation to include paymentCbor in the import summary.
- Updated the paymentCbor field in the NewWallet model to be optional in schema.prisma. - Removed the migration file that previously enforced paymentCbor as a required field.
…ields - Removed optional fields related to user and community information from the ejection API documentation to streamline the payload requirements.
…BOR fields - Added `stakeCbor` and `usesStored` fields to the NewWallet model in schema.prisma. - Updated the migration script to include the new `paymentCbor` field correctly. - Modified the ejection redirect API to handle `stakeCbor` and `usesStored` during wallet creation and updates. - Enhanced multisig import validation to incorporate the new fields in the import summary.
…ture matching - Added functionality to collect and match signature key hashes for both payment and stake scripts during multisig import validation. - Introduced new `sigMatches` field in the import summary to provide detailed results of signature matches. - Updated the validation logic to reorder signer addresses based on payment script key hash order.
…validation - Enhanced the validation logic to order signer stake keys based on payment script key hash order when necessary. - Implemented logic to build reward addresses for matched stake keys, falling back to key hashes when address construction fails. - Updated the return structure to reflect the new ordering of signer stake keys and resolved stake addresses used.
…cessing and expanded address matching - Changed `validateMultisigImportPayload` to be asynchronous, allowing for improved handling of address resolution. - Introduced `matchPaymentSigsExpanded` to fetch additional payment addresses from stake accounts when necessary. - Enhanced the logic for processing signer addresses to ensure proper matching with required key hashes.
…hancements - Expanded README to include new `stakeCbor` field in the multisig wallet upsert process. - Added notes on handling `multisig_id`, community description, and database write failures. - Updated redirect API to normalize request body for signersDescriptions, ensuring consistent handling of input data.
…raw import bodies - Added `user_name` field to the ejection API documentation and payload structure. - Updated the `NewWallet` model to include `rawImportBodies` for improved data handling. - Modified the validation logic to incorporate user names in the signer descriptions, ensuring consistent data processing.
- Updated the ownerAddress field in the ejection redirect API to consistently use "all" across multiple instances, ensuring uniformity in the request payload.
- Deleted the ejection redirect API implementation and its associated README documentation as part of a cleanup effort. - Updated validation logic to accommodate new payload structure for multisig imports, ensuring compatibility with the latest API design.
…n user array is empty - Added logic to fallback on deriving users from stakeCbor if the users array is empty during multisig import validation. - Implemented error handling to log warnings if the user derivation process fails, ensuring robustness in user data processing.
…alidation logic - Enhanced the validation process to align stake keys with signer addresses when payment and stake scripts are identical. - Implemented logic to recompute stake addresses used based on the reordered stake keys, ensuring positional alignment. - Improved fallback mechanisms for address resolution to handle cases where key hashes do not match directly.
- Updated the fallback mechanism in the validation logic to return an empty string instead of the payment signature when no matching stake key is found. - Ensured consistency in handling stake key hashes by aligning the return values with the expected format.
…mport-api refactor(api): update signer descriptions and enhance multisig import summary
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…multisig validation - Updated the description handling in the wallet import API to use a new `sanitizeDescription` function, improving security by escaping HTML entities. - Refactored the multisig import validation to utilize a `sanitizeText` function for user names, ensuring consistent sanitization across both modules.
- Introduced a new `removeTagsLinear` function for consistent tag removal in both wallet import and multisig validation processes. - Updated the `sanitizeDescription` and `sanitizeText` functions to utilize the new tag removal logic, enhancing code maintainability and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.