Skip to content

Update ReviewRequiredSignersCard to prevent state updates during editing #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QSchlegel merged 1 commit into from
Nov 24, 2025
Merged

Update ReviewRequiredSignersCard to prevent state updates during editing #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/components/pages/homepage/wallets/new-wallet-flow/create/ReviewRequiredSignersCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ const ReviewRequiredSignersCard: React.FC<ReviewRequiredSignersCardProps> = ({
const [isEditing, setIsEditing] = useState(false);
const [tempNumRequired, setTempNumRequired] = useState(numRequiredSigners);

// Update temp states when props change
// Update temp states when props change (but not when editing)
useEffect(() => {
setTempNumRequired(numRequiredSigners);
}, [numRequiredSigners]);
if (!isEditing) {
setTempNumRequired(numRequiredSigners);
}
}, [numRequiredSigners, isEditing]);

// Exit edit mode if script type changes from atLeast to something else
useEffect(() => {
Expand Down Expand Up @@ -102,9 +104,14 @@ const ReviewRequiredSignersCard: React.FC<ReviewRequiredSignersCardProps> = ({
<div className="w-full overflow-x-auto pb-2">
<ToggleGroup
type="single"
value={tempNumRequired.toString()}
value={tempNumRequired > 0 ? tempNumRequired.toString() : undefined}
onValueChange={(v) => {
if (v) setTempNumRequired(Number(v));
if (v && v !== "" && !isNaN(Number(v))) {
const newValue = Number(v);
if (newValue > 0 && newValue <= signersCount) {
setTempNumRequired(newValue);
}
}
}}
className="justify-start flex-nowrap"
>
Expand Down
Loading