Feature/api-transaction-fetching-and-signing#177
Merged
Conversation
- Updated README.md to include details about the new GET /api/v1/pendingTransactions endpoint, covering its purpose, authentication, features, query parameters, response structure, and error handling. - Added Swagger documentation for the pendingTransactions endpoint, specifying request parameters and expected responses.
- Removed outdated details from README.md regarding the signTransaction endpoint and streamlined the description. - Updated the signTransaction handler to improve request validation and error handling, replacing the signedTx parameter with txCbor. - Enhanced the logic for broadcasting transactions and managing state transitions. - Removed Swagger documentation for the signTransaction endpoint to reflect the changes in request parameters and responses.
…andling - Introduced new parameters for signature and key, replacing the previous txCbor parameter. - Added functions for hex normalization and error handling. - Enhanced transaction processing logic, including signature verification and witness management. - Updated transaction submission logic to use the correct transaction hex format. - Improved error logging for better debugging.
- Updated the signTransaction handler to incorporate new parameters for signature and key, replacing the txCbor parameter. - Improved validation and error handling mechanisms. - Enhanced transaction processing logic, including signature verification and witness management. - Adjusted transaction submission logic to ensure correct transaction hex format. - Improved error logging for better debugging capabilities.
…ss management - Normalized transaction hash to lowercase for consistency. - Introduced witness summaries for better tracking of signatures and public keys. - Improved transaction hash validation and error handling for provided transaction hashes. - Refactored transaction state management and updated transaction JSON structure to include multisig details. - Enhanced error responses for better clarity on transaction submission issues.
- Removed the txHash parameter and associated validation logic for improved clarity. - Streamlined the resolveNetworkId function to enhance address handling. - Adjusted transaction submission logic to ensure proper state management without relying on provided transaction hashes.
…cumentation - Added mock implementations for database transaction updates and console error/warn handling in tests. - Updated the signTransaction API documentation in Swagger to include detailed request and response structures. - Improved test coverage for transaction updates and error handling scenarios.
…n endpoint - Added comprehensive information about the signTransaction endpoint, including its purpose, authentication requirements, features, request body, response structure, and error handling. - Enhanced clarity on the transaction submission process and the role of signer witnesses.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
QSchlegel
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sign tx api and tests for sign and pending tx apis