Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required to facilitate running of pp_demo_suite using head of dagrunner #43

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

cpelley
Copy link
Collaborator

@cpelley cpelley commented Jul 8, 2024

Reverted change from #40 involving common args handling and filled in gap in testing to ensure we continue to support reliant behaviour.

Working pp_demo_workflow when using this dagrunner dev branch:
http://fcm1/cylc-review/taskjobs/cpelley?&suite=demo_workflow_dagrunner_head&no_fuzzy_time=0&tasks=execute_basic_model

Best explained from looking at the new testcase:

Passing 'common args' to a plugin that doesn't have such arguments
defined in its signature. Instead, filter out those that aren't
specified in the graph.

Issues

@cpelley cpelley added the bug Something isn't working label Jul 8, 2024
@cpelley cpelley self-assigned this Jul 8, 2024
@cpelley cpelley changed the title Revert change in behaviour from #40 relating to common args Changes required to facilitate running of pp_demo_suite using head of dagrunner Jul 8, 2024
@cpelley cpelley marked this pull request as ready for review July 8, 2024 14:18
@cpelley cpelley merged commit 0571bea into main Jul 8, 2024
2 checks passed
@cpelley cpelley deleted the WORKING_DEMO_REPO branch July 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants