Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some graph rendering broken after 11.0 #75

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

cpelley
Copy link
Collaborator

@cpelley cpelley commented Feb 4, 2025

I have raised an issue with the mermaid repository here: mermaid-js/mermaid#6251
Not all graph rendering is broken, only seemingly large ones.

Background

We recently bumped mermaid version in #74 (using latest).
Everything works fine in our small graph rendering examples (integration tests). Upon rendering full configurations the issue presents (some configurations).

image

@cpelley cpelley self-assigned this Feb 4, 2025
@cpelley cpelley changed the title Brocken graph rendering after 11.0 Broken graph rendering after 11.0 Feb 4, 2025
@cpelley cpelley marked this pull request as draft February 4, 2025 16:07
@cpelley cpelley changed the title Broken graph rendering after 11.0 Broken graph rendering for large graphs after 11.0 Feb 4, 2025
@cpelley cpelley changed the title Broken graph rendering for large graphs after 11.0 Some graph rendering broken after 11.0 Feb 4, 2025
@cpelley cpelley marked this pull request as ready for review February 7, 2025 09:02
@cpelley cpelley merged commit 7e58fef into main Feb 7, 2025
1 check passed
@cpelley cpelley deleted the pin_mermaid_version branch February 7, 2025 09:02
@cpelley
Copy link
Collaborator Author

cpelley commented Feb 7, 2025

this isn't a controversial change, just the pinning of mermaid, so merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant