-
Notifications
You must be signed in to change notification settings - Fork 3
Update the cla-check #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
|
Hi @yaswant this one is now ready for review. I've done a couple of PRs in git_playground to demonstrate:
|
yaswant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine James. Just a minor suggestion to reduce network calls.
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
|
It looks like the colour and description entries in the label api calls were the wrong way round. Works as expected now |
yaswant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-bruten-mo I have a strong feeling that we can shorten this workflow, perhaps in a separate PR. However, based on your tests I am happy to approve this for main.

Merging the changes from #50 into main having been verified on the develop branch in the git playground