Skip to content

#81: Fix unallocated arrays in ukca_volcanic_so2 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcdalvi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

#81: Fix unallocated arrays in ukca_volcanic_so2 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c22211
Re-apply lost changes after incorrect sync
mcdalvi Jan 15, 2026
49a8a2d
Improve error message after review
mcdalvi Jan 19, 2026
be243e9
Merge branch 'main' into fix_i81_ukca_volc
oakleybrunt Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
| DrTVockerodtMO | Terence Vockerodt | Met Office | 2026-01-08 |
| MetBenjaminWent | Benjamin Went | Met Office | 2026-01-15 |
| timgraham-Met | Tim Graham | Met Office | 2026-01-15 |
| mo-alistairp | Alistair Pirrie | Met Office | 2026-01-19 |
| mcdalvi | Mohit Dalvi | Met Office | 2026-01-15 |
| mo-alistairp | Alistair Pirrie | Met Office | 2026-01-19 |
18 changes: 18 additions & 0 deletions interfaces/physics_schemes_interface/source/legacy/ukca_interface/ukca_volcanic_so2.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,19 @@ subroutine ukca_volcanic_so2 &

if (lhook) call dr_hook(ModuleName//':'//RoutineName,zhook_in,zhook_handle)

! Functionality is not currently implemented in LFRic.
errcode = 1
cmessage = 'Volcanic SO2 emissions not yet implemented.' // &
'Logical l_ukca_so2ems_expvolc should be set to .false.'
call ereport(RoutineName, errcode, cmessage)

! Allocate true_latitude, true_longitude arrays and initialise temporarily.
! These should be subsequently populated from LFRic w3 fields.
if ( .not. allocated(true_latitude)) allocate(true_latitude(row_length,rows))
if ( .not. allocated(true_longitude)) allocate(true_longitude(row_length,rows))
true_latitude(:,:) = 0.0
true_longitude(:,:) = 0.0

! On first call, determine locations on the UM grid where volcanos are located.
! The method assumes that the grid is a regular latitude-longitude grid with
! latitude constant on each row and equally-spaced between rows and
Expand Down Expand Up @@ -334,6 +347,7 @@ subroutine ukca_volcanic_so2 &
l2 = l2 - 1
end do
if (l2 < l1) l1 = l2
allocate(weight_volc_vertdist(l2-l1+1))
! express emission as increase in average increase in mass mixing ratio
weight_volc_vertdist = (abs(r_theta_levels(i,j,l1+1:l2+1) - &
r_theta_levels(i,j,l1-1:l2-1))/2) * &
Expand All @@ -343,10 +357,14 @@ subroutine ukca_volcanic_so2 &
so2_mmr(i,j,l1:l2) = so2_mmr(i,j,l1:l2) + emission(k) * &
(weight_volc_vertdist/sum(weight_volc_vertdist)) / &
mass(i,j,l1:l2)
deallocate(weight_volc_vertdist)
end if
end if
end do

if (allocated(true_latitude)) deallocate(true_latitude)
if (allocated(true_longitude)) deallocate(true_longitude)

if (lhook) call dr_hook(ModuleName//':'//RoutineName,zhook_out,zhook_handle)
return
end subroutine ukca_volcanic_so2
Expand Down