-
Notifications
You must be signed in to change notification settings - Fork 48
Decompose across panels #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The Apps part of this ticket is very straightforward, and I already science reviewed it on trac. As we noted elsewhere, the changes to the plotting script will conflict with #74. However I think this branch is picking up on some changes to the Otherwise I'll be happy for this to proceed. |
I've removed the changes to local_build |
PR Summary
Sci/Tech Reviewer: @tommbendall
Code Reviewer: @christophermaynard
This is a port of the previous SRS ticket (https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1070) & its linked ticket https://code.metoffice.gov.uk/trac/lfric/ticket/4699 Both these tickets have already been science and code reviewed on the SRS and will go to the same reviewers here to check for any further issues.
In detail, the aim of this ticket is to modify the existing partitioning strategy so that it can partition multiple panels (either 3 sets of 2 or 2 sets of 3) into uniform rectangular domains. This will mean that the number of mpi ranks needs to only have a factor of 2 or 3 instead of 6 as a base requirement.
Using this option means that code that assumes all owned cells are on the same panel (we think only the extended mesh in the transport code) will not give the correct results here.
As part of this change I have also fixed the plotting script for the baroclinic wave on azspice where the figures were not coming out correct
Code Quality Checklist
Testing
This change has been well tested & used in the Dec2025 KPI report for the global lfric model and is required to run the model on the target ~100 nodes at C896 resolution
trac.log
Test Suite Results - lfric_apps - decompose_across_panels/run7
Suite Information
Task Information
✅ succeeded tasks - 1115
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review