Refactor of damping layer matrix #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmelvin
added
the
Linked Core
github-actions
bot
added
cla-signed
thomasmelvin
removed
the
Linked Core
Author
|
Results from a selection of tests which have altered KGO's. Top plots are on this branch, bottom plots are from the stable branch AgnesiVertical velocity Branch
Trunk
Deep hot Jupiteru wind field Branch
Trunk
nwp-gal9 C48u wind field Branch
Trunk
ral3-seuku wind field Branch
Trunk
Schar hillvertical velocity Branch
Trunk
Thai-Benpotential temperature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @mo-lucy-gordon
This change refactors the computation of the damping layer kernel to improve the efficiency of the code. As the computation order is reordered this results in small changes to kgos for all tests that use the damping layer
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - refactor_dl_matrix/run3
Suite Information
Task Information
❌ failed tasks - 84
✅ succeeded tasks - 1371
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review