Skip to content

Floating-point precision conversions in jelf #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom-j-h wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Floating-point precision conversions in jelf #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01c2c93
Precision conversions
tom-j-h Jan 14, 2026
d5ca8ea
Merge branch 'main' into jelf_precision_conversions
tom-j-h Jan 15, 2026
0c39582
Contributors
tom-j-h Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
| oakleybrunt | Oakley Brunt | Met Office | 2025-12-19 |
| harry-shepherd | Harry Shepherd | Met Office | 2026-01-08 |
| DrTVockerodtMO | Terence Vockerodt | Met Office | 2026-01-08 |
| tom-j-h | Tom Hill | Met Office | 2026-01-14 |
4 changes: 2 additions & 2 deletions applications/jedi_lfric_tests/source/jedi_id_tlm_tests.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,10 @@ program jedi_id_tlm_tests
! Apply the Adjoint dot product test: <I11,I21> == <I12,I22>

! Evaluate dot product of increments I11 and I21 <I11,I21>
dot_product_1 = increment_11%dot_product_with(increment_21)
dot_product_1 = real(increment_11%dot_product_with(increment_21), r_def)

! Evaluate dot product of increments I12 and I22 <I12,I22>
dot_product_2 = increment_12%dot_product_with(increment_22)
dot_product_2 = real(increment_12%dot_product_with(increment_22), r_def)

! <I11,I21> == <I12,I22>
! The two dot products should be nearly identical. The tolerance is
Expand Down
4 changes: 2 additions & 2 deletions applications/jedi_lfric_tests/source/jedi_tlm_tests.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ program jedi_tlm_tests
end if

! Compute <Mx,Mx>
dot_product_1 = inc%scaled_dot_product_with_itself()
dot_product_1 = real(inc%scaled_dot_product_with_itself(), r_def)

! Propagate via AD model
call linear_model%forecastAD( inc, forecast_length )
Expand All @@ -158,7 +158,7 @@ program jedi_tlm_tests
end if

! Compute <AMx,x>
dot_product_2 = inc%dot_product_with(inc_initial)
dot_product_2 = real(inc%dot_product_with(inc_initial), r_def)

! The two dot products should be nearly identical. The tolerance is included
! due to differences in order of operations and solver non-convergence.
Expand Down
8 changes: 4 additions & 4 deletions interfaces/jedi_lfric_interface/source/field/atlas_field_interface_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ module atlas_field_interface_mod
use field_mod, only : field_type, field_proxy_type
use field_parent_mod, only : field_parent_type
use fs_continuity_mod, only : W3, Wtheta, name_from_functionspace
use constants_mod, only : i_def, str_def, l_def
use constants_mod, only : i_def, str_def, l_def, r_def

implicit none

Expand Down Expand Up @@ -394,7 +394,7 @@ subroutine copy_to_lfric( self, return_code )
atlas_ij = self%map_horizontal(ij)
lfric_ij = (ij-1)*n_vertical_lfric
field_proxy%data(lfric_ij+lfric_kstart:lfric_ij+n_vertical_lfric) &
= self%atlas_data(atlas_kstart:atlas_kend:atlas_kdirection,atlas_ij)
= real(self%atlas_data(atlas_kstart:atlas_kend:atlas_kdirection,atlas_ij), r_def)
end do

! Fill missing data if required
Expand All @@ -410,7 +410,7 @@ subroutine copy_to_lfric( self, return_code )
atlas_ij = self%map_horizontal(ij)
lfric_ij = (ij-1)*n_vertical_lfric
field_proxy%data(lfric_ij+1) &
= self%atlas_data(atlas_kstart,atlas_ij)
= real(self%atlas_data(atlas_kstart,atlas_ij), r_def)
end do
end if

Expand Down Expand Up @@ -466,7 +466,7 @@ subroutine copy_from_lfric_ad(self)
lfric_ij = (ij-1)*n_vertical_lfric
field_proxy%data(lfric_ij+lfric_kstart:lfric_ij+n_vertical_lfric) &
= field_proxy%data(lfric_ij+lfric_kstart:lfric_ij+n_vertical_lfric) &
+ self%atlas_data(atlas_kstart:atlas_kend:atlas_kdirection,atlas_ij)
+ real(self%atlas_data(atlas_kstart:atlas_kend:atlas_kdirection,atlas_ij), r_def)
end do

! Initialise out of scope variable to zero
Expand Down