File metadata and Forecast reference Time Scalar to reduce post processing from lfric core #90
Conversation
|
@mo-marqh - Before I review can i seek clarification about the failing tests listed in the description, is this PR ready for review? Also, could you rename the PR to give a better desctiption of the changes please |
failing tests need fixing, there are only two left to do, I'll get right on that. Pr renamed |
mo-marqh
changed the title
|
regarding the two failing rose ana tests in lfric inputs @mo-lottieturner these are due to the new forecast_reference_time coordinate being included in the output file and referenced by the data variables. so, in the updated & reference changes such as are added. this is expected behaviour for this change, but would benefit from @mo-lottieturner 's view if approved, then i think that static data files located in |
|
cross checking with input UM file: noting
import iris.fileformats.um as um
fields = list(um.um_to_pp('/home/users/umadmin/standard_jobs/lfricinputs/inputs/aquaplanet.lbc.ff'))
[print(f'lbtim: {f.lbtim} | lbyr: {f.lbyrd} | lbmond: {f.lbmond} | lbdatd: {f.lbdatd} | lbhrd: {f.lbhrd} | lbmind: {f.lbmind} | lbsecd: {f.lbsecd}') for f in fields[0:1]]which is consistent with (noting that |
2 participants
PR Summary
Sci/Tech Reviewer: @EdHone
Code Reviewer: @ericaneininger
This change provides extra configuration to the output file metadata, using an XIOS
scalarto define a container for a forecast reference time that will be populated by lfric_core's lfric_xios interface (see linked PR)Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
and have tests been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_apps - scalar_frt/run2
Suite Information
Task Information
❌ failed tasks - 2
✅ succeeded tasks - 1102
⌛ waiting tasks - 2
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
inteface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review