Skip to content

Bug in AOD diagnostics #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanjhewitt wants to merge 4 commits into
base: main
Choose a base branch
from
+37 −12
Open

Bug in AOD diagnostics #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f2238f
41 : Fix addressing bug in radaer aerosol AOD
alanjhewitt Dec 16, 2025
e8c8f31
41 : Add AOD to rose-stem diagnostics
alanjhewitt Dec 16, 2025
8f8d3c8
Merge branch 'MetOffice:main' into AOD_bug
alanjhewitt Jan 7, 2026
1793ba1
Add my name to contributors list
alanjhewitt Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
| mo-marqh | mark Hedley | Met Office | 2025-12-11 |
| yaswant | Yaswant Pradhan | Met Office | 2025-12-16 |
| oakleybrunt | Oakley Brunt | Met Office | 2025-12-19 |
| alanjhewitt | Alan J Hewitt | Met Office | 2026-01-07 |
36 changes: 24 additions & 12 deletions interfaces/physics_schemes_interface/source/kernel/radaer_kernel_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,15 +1139,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_ait_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_ait_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_ait_sol( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_ait_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_ait_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_ait_sol( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down Expand Up @@ -1224,15 +1226,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_acc_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_acc_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_acc_sol( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_acc_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_acc_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_acc_sol( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down Expand Up @@ -1309,15 +1313,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_cor_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_cor_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_cor_sol( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_cor_sol, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_cor_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_cor_sol( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down Expand Up @@ -1394,15 +1400,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_ait_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_ait_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_ait_ins( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_ait_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_ait_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_ait_ins( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down Expand Up @@ -1479,15 +1487,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_acc_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_acc_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_acc_ins( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_acc_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_acc_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_acc_ins( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down Expand Up @@ -1564,15 +1574,17 @@ subroutine radaer_code( nlayers, &
if ( .not. associated( aod_ukca_cor_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aod_ukca_cor_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
aod_ukca_cor_ins( map_aod_wavel(i) + k - 1 ) = &
aod_ukca_this_mode_um(i,k)
end do
end do
end if

if ( .not. associated( aaod_ukca_cor_ins, empty_real_data ) ) then
do k = 1, npd_ukca_aod_wavel
do i = 1, row_length
aaod_ukca_cor_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
aaod_ukca_cor_ins( map_aod_wavel(i) + k - 1 ) = &
aaod_ukca_this_mode_um(i,k)
end do
end do
end if
Expand Down
12 changes: 12 additions & 0 deletions rose-stem/app/lfric_coupled/file/mydef.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,18 @@
<field field_ref="chemistry__dmso" />
<field field_ref="chemistry__monoterpene" />
<field field_ref="chemistry__secondary_organic" />
<field field_ref="aerosol__aod_ukca_ait_sol" />
<field field_ref="aerosol__aaod_ukca_ait_sol" />
<field field_ref="aerosol__aod_ukca_acc_sol" />
<field field_ref="aerosol__aaod_ukca_acc_sol" />
<field field_ref="aerosol__aod_ukca_cor_sol" />
<field field_ref="aerosol__aaod_ukca_cor_sol" />
<field field_ref="aerosol__aod_ukca_ait_ins" />
<field field_ref="aerosol__aaod_ukca_ait_ins" />
<field field_ref="aerosol__aod_ukca_acc_ins" />
<field field_ref="aerosol__aaod_ukca_acc_ins" />
<field field_ref="aerosol__aod_ukca_cor_ins" />
<field field_ref="aerosol__aaod_ukca_cor_ins" />
<field field_ref="aerosol__n_nuc_sol" />
<field field_ref="aerosol__n_ait_sol" />
<field field_ref="aerosol__n_acc_sol" />
Expand Down
Loading