Skip to content

Conversation

@bblay-mo
Copy link

@bblay-mo bblay-mo commented Jan 7, 2026

  • Fixes a FileExistsError in extract_science.py when rebuilding.
  • Updates the copy to only target newer files.

Note: There is a subsequent error in the dependerator when rebuilding (not related to the changes in this pr). The workaound is: rm applications/lfric_atm/working/build_lfric_atm/dependencies.db

Todo:

  • Stem test failing from timeout. Investigating

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
    style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource
    and have tests been allocated to an appropriate testing group (i.e. the
    developer tests are for jobs which use a small amount of compute resource
    and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

PSyclone Approval

  • If you have edited any psyclone related code (eg. PsyKAl-lite, Kernal
    inteface, optimisation scripts, LFRic data structure code) then please
    contact the
    tooscollabdevteam@metoffice.gov.uk

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required CLA signature is required for this PR. label Jan 7, 2026
@bblay-mo bblay-mo changed the title Rebuild fix extract_scient.py rebuild fix Jan 7, 2026
@bblay-mo bblay-mo changed the title extract_scient.py rebuild fix extract_science.py rebuild fix Jan 7, 2026
@github-actions github-actions bot added cla-signed This contributor has signed the CLA. and removed cla-required CLA signature is required for this PR. labels Jan 7, 2026
run_command(f"mkdir -p {dest_file.parents[0]}")
copy_command = f"cp -r {source_file} {dest_file}"
dest_file.parent.mkdir(parents=True, exist_ok=True)
copy_command = f"cp -r -u --preserve=timestamps {source_file} {dest_file}"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're invoking a CLI tool, we could consider using rsync, which can remove files too.


# make the working directory location
working_dep.mkdir(parents=True)
working_dep.mkdir(parents=True, exist_ok=True)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is almost certainly redundant, so we could remove it instead of fixing it.

@bblay-mo bblay-mo marked this pull request as ready for review January 9, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed This contributor has signed the CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant