Verniered time calipers pi25 #202
Conversation
mo-marqh
requested review from
EdHone,
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
as code owners
mo-marqh
requested review from
t00sa
and removed request for
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
|
The set of new calipers and the implementation all look sound to me @mo-marqh, I have had some issues building the code with vernier though. I checked out your core branch and attempted to build simple diffusion with the |
EdHone
left a comment
EdHone
left a comment
There was a problem hiding this comment.
Mostly fine - the timers themselves make sense are consistent with those from the KPI exercise in late 2025.
Just a few small requests and queries
| character(*), optional, intent(in) :: value_name | ||
| character(str_def) :: restart_id | ||
| integer(i_def) :: array_dims | ||
| integer(tik) :: id |
There was a problem hiding this comment.
Could you change this to something like prof_id or timer_id? Just because there are lots of id variables that get thrown around with XIOS and this is something different.
| integer(i_def) :: vdim ! vertical dimension | ||
| real(dp_xios), allocatable :: xios_data(:) | ||
| logical(l_def) :: legacy | ||
| integer(tik) :: id |
There was a problem hiding this comment.
As with the above comment, please could you rename to something less ambiguous
| integer(i_def) :: vdim ! vertical dimension | ||
| real(dp_xios), allocatable :: xios_data(:) | ||
| logical(l_def) :: legacy | ||
| integer(tik) :: id |
There was a problem hiding this comment.
Please could you rename to something less ambiguous
|
|
||
| type(linked_list_item_type), pointer :: loop => null() | ||
| type(lfric_xios_file_type), pointer :: file => null() | ||
| integer(tik) :: idlx, idxc |
There was a problem hiding this comment.
What's the purpose of having two IDs here?
3 participants
PR Summary
Sci/Tech Reviewer: @EdHone
Code Reviewer: @t00sa
This stand alone change is part of a change set targeting performance management and optimisation, derived from https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1002
This change set targets the additional and renamed calipers for timings within
lfric_core.Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - verniered_time_calipers_PI25/run4
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review