Skip to content

Fix averaging kernel used in stochastic physics filter #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tommbendall wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix averaging kernel used in stochastic physics filter #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
751593b
correct filter
tommbendall Jan 15, 2026
df8c4e1
sign contributors again but for this branch...
tommbendall Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
| jennyhickson | Jenny Hickson | Met Office | 2025-12-10 |
| mo-marqh | Mark Hedley | Met Office | 2025-12-11 |
| MatthewHambley | Matthew Hambley | Met Office | 2025-12-15 |
| tommbendall | Thomas Bendall | Met Office | 2026-01-15 |
8 changes: 5 additions & 3 deletions components/science/source/kernel/inter_function_space/sci_wth_to_w0_average_kernel_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ subroutine wth_to_w0_average_code(nlayers, &
! Internal variables
integer(kind=i_def) :: df, k

do k = 0, nlayers
do df = 1,4 ! Loop at the Bottom
field_w0(map_w0(df) + k) = field_w0(map_w0(df) + k) + field_wth(map_wtheta(1) + k)*rmultiplicity_w0(map_w0(df) + k)
do df = 1, 4 ! Use bottom four W0 DoFs in cell
do k = 0, nlayers
! Use rmultiplicity from bottom layer to ensure appropriate average
field_w0(map_w0(df) + k) = field_w0(map_w0(df) + k) &
+ field_wth(map_wtheta(1) + k)*rmultiplicity_w0(map_w0(df))
end do
end do

Expand Down