Skip to content

Conversation

@Pierre-siddall
Copy link
Contributor

@Pierre-siddall Pierre-siddall commented Jan 19, 2026

PR Summary

Code Reviewer:

This PR moves the pylint.rc file into the top level of the MOCI repository so that future linting actions can make use of .

closes #14

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the Moci rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required CLA signature is required for this PR. label Jan 19, 2026
@github-actions github-actions bot added cla-signed This contributor has signed the CLA. and removed cla-required CLA signature is required for this PR. labels Jan 19, 2026
@Pierre-siddall Pierre-siddall self-assigned this Jan 19, 2026
@Pierre-siddall Pierre-siddall marked this pull request as ready for review January 19, 2026 14:34
@Pierre-siddall Pierre-siddall requested review from a team, mo-ssd-bot and t00sa and removed request for a team and mo-ssd-bot January 19, 2026 14:34
@Pierre-siddall Pierre-siddall changed the title move-pylint.rc Move pylint.rc Jan 19, 2026
@yaswant
Copy link
Collaborator

yaswant commented Jan 19, 2026

I'd suggest you hold this one as we aim to favour ruff over pylint. Please find out if pylint is still desirable for more sophisticated checks that is missing in ruff for this repository first.

@Pierre-siddall Pierre-siddall removed the request for review from t00sa January 20, 2026 08:10
@Pierre-siddall Pierre-siddall marked this pull request as draft January 20, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed This contributor has signed the CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move pylint.rc out of utilities

2 participants