Skip to content

Conversation

@mo-jmanners
Copy link
Member

@mo-jmanners mo-jmanners commented Jan 14, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo

closes #9

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • Trivial change that does not affect UM or LFRic builds.

  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites

  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)

  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

  • make_tar script runs successfully
  • changes to userguide build with latex

trac.log

  • NA

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-signed This contributor has signed the CLA. label Jan 14, 2026
Copy link
Collaborator

@james-bruten-mo james-bruten-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James, looks good

@james-bruten-mo james-bruten-mo merged commit 11758c6 into MetOffice:main Jan 15, 2026
3 checks passed
@mo-jmanners mo-jmanners deleted the 9_tidy_scripts branch January 15, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed This contributor has signed the CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tidy up references to FCM

2 participants