Conversation
Contributor
Screen.Recording.2026-02-05.at.2.20.51.PM.movEDITAfter testing further I see that even if my initial connection is with the legacy connector I see that same error 🤔 I'm starting to wonder whether we should even have this error "Requests cannot be made to chains not explicitly configured in supportedNetworks." |
This reverts commit 812faaa.
adonesky1
reviewed
Feb 19, 2026
adonesky1
reviewed
Feb 19, 2026
adonesky1
reviewed
Feb 19, 2026
Contributor
Author
|
PR desc updated |
ffmcgee725
reviewed
Feb 20, 2026
ffmcgee725
reviewed
Feb 20, 2026
ffmcgee725
reviewed
Feb 20, 2026
ffmcgee725
reviewed
Feb 20, 2026
ffmcgee725
reviewed
Feb 20, 2026
wenfix
previously approved these changes
Feb 20, 2026
chakra-guy
reviewed
Feb 20, 2026
packages/connect-multichain/src/multichain/transports/multichainApiClientWrapper/index.ts
Outdated
Show resolved
Hide resolved
…inApiClientWrapper/index.ts Co-authored-by: Tamas <tamas.soos94@gmail.com>
adonesky1
approved these changes
Feb 20, 2026
Contributor
adonesky1
left a comment
There was a problem hiding this comment.
LGTM! Let's go!!! Amazing work Jiexi 🚀 🚀 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces a singleton pattern for the Multichain SDK that shifts the source of truth for connection status for downstream ecosystem clients (ConnectEVM, ConnectSolana) to the
wallet_sessionChangedevent.Adds a singleton for the actual MetaMaskConnectMultichain instance itself with logic to merge incoming constructor options with the existing constructor options of the singleton
Removes the
disconnect()onconnect()patternCalling
connect()while there is an inflight MWP connection results in a'Existing connection is pending. Please check your MetaMask Mobile app to continue.'error being thrownwallet_requestPermissionsalready pending for origin...)connect()is now additive and will combine the requested scopes and accounts with the existing (if any)wallet_revokeSessioncall inDefaultTransport.connect()disconnect()now supports partial revokes. If some scopes still remain after a partial revoke, the underlying connection remains intact and can be reused.Fix/Adjust Browser Playground
connecteventMakes
wallet_sessionChangedthe source of truth forConnectEvmand future ecosystem clientsAddresses: https://consensyssoftware.atlassian.net/browse/WAPI-1066
References
Checklist