Skip to content

fix(connect-multichain): clean up MWP session on connection rejection #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiexi merged 3 commits into from
Feb 20, 2026
Merged

fix(connect-multichain): clean up MWP session on connection rejection #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b094194
fix(connect-multichain): clean up MWP session on connection rejection
adonesky1 Feb 20, 2026
991bb04
lint + changelog
adonesky1 Feb 20, 2026
3d17643
more changelog
adonesky1 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/connect-multichain/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix `beforeunload` event listener not being properly removed on disconnect due to `.bind()` creating different function references, causing a listener leak on each connect/disconnect cycle ([#170](https://github.com/MetaMask/connect-monorepo/pull/170))
- Rename `StoreAdapterWeb.DB_NAME` from `mmsdk` to `mmconnect` to prevent IndexedDB collisions when the legacy MetaMask SDK and MM Connect run in the same browser context ([#177](https://github.com/MetaMask/connect-monorepo/pull/177))
- Clean up stale MWP session from KVStore on connection rejection so subsequent QR code connection attempts are not blocked ([#180](https://github.com/MetaMask/connect-monorepo/pull/180))

## [0.5.3]

Expand Down
5 changes: 4 additions & 1 deletion packages/connect-multichain/src/multichain/transports/mwp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,10 @@ export class MWPTransport implements ExtendedTransport {
});

return connectionPromise
.catch((error) => {
.catch(async (error) => {
// Clean up the MWP session from the KVStore so stale sessions
// don't cause subsequent connect attempts to enter the resume path
await this.dappClient.disconnect();
throw error;
})
.finally(() => {
Expand Down
Loading