Skip to content
Main

Update NotificationServicesController to accommodate for Snaps Notifications #12393

Sign in to view logs

Update NotificationServicesController to accommodate for Snaps Notifications

Update NotificationServicesController to accommodate for Snaps Notifications #12393

Triggered via pull request October 17, 2024 17:54
@hmalik88hmalik88
synchronize #4809
hm/add-snap-notifications
Status Failure
Total duration 3m 49s
Artifacts –

main.yml

on: pull_request
Check workflows
4s
Check workflows
Matrix: Lint, build, and test / Prepare
Matrix: Lint, build, and test / Build
Matrix: Lint, build, and test / Lint
Matrix: Lint, build, and test / Test
Matrix: Lint, build, and test / Validate changelog
All jobs complete
0s
All jobs complete
Determine whether this is a release merge commit
0s
Determine whether this is a release merge commit
All jobs pass
0s
All jobs pass
Publish release  /  publish-release
Publish release / publish-release
Publish release  /  publish-npm-dry-run
Publish release / publish-npm-dry-run
Publish release  /  publish-npm
Publish release / publish-npm
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 1 warning
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts#L42
`./__fixtures__` import should occur before import of `./__fixtures__/mock-feature-announcements`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts#L43
All imports in the declaration are only used as types. Use `import type`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts#L43
`./types` import should occur before import of `./types/user-storage/user-storage`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts#L44
`./constants` import should occur before import of `./NotificationServicesController`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts#L45
`./processors/process-snap-notifications` import should occur before import of `./services/onchain-notifications`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts#L34
There should be at least one empty line between import groups
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts#L35
'@metamask/utils' should be listed in the project's dependencies. Run 'npm i -S @metamask/utils' to add it
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts#L35
`@metamask/utils` import should occur before import of `loglevel`
Lint, build, and test / Lint (20.x): packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts#L35
"@metamask/utils" is extraneous
Lint, build, and test / Lint (20.x)
Process completed with exit code 1.
All jobs pass
Process completed with exit code 1.
Check workflows
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/