feat: migrate NftController to BaseControllerV2

[cryptodev-2s]

Explanation

The NftController has been migrated to BaseControllerV2. As part of this migration the following changes were made:

• The deprecated config property has been removed and has been replaced with flatten properties on the controller constructor options (selectedAddress, ipfsGateway, openSeaEnabled, useIPFSSubdomains, isIpfsGatewayEnabled and NftControllerState).

• This PR includes a type conversion, changing from an interface to a type alias in TypeScript to improve type management and flexibility for Nft, NftContract, NftMetadata.

• getDefaultNftState has been renamed to getDefaultNftControllerState and NftState has been renamed to NftControllerState.

References

• Fixes Convert NftController from BaseControllerV1 to BaseControllerV2 #4073

Changelog

@metamask/assets-controllers

• BREAKING: Convert NftController toBaseControllerV2
  • The constructor parameters have changed, rather than accepting a "config" parameter, it takes selectedAddress, ipfsGateway, openSeaEnabled, useIPFSSubdomains and isIpfsGatewayEnabled as parameters.
• CHANGED: type conversion, changing from an interface to a type alias for Nft, NftContract, NftMetadata and NftControllerState.
• CHANGED: getDefaultNftState has been renamed to getDefaultNftControllerState and NftState has been renamed to NftControllerState.
• ADDED: Exports new added types: NftControllerActions, NftControllerGetStateAction, NftControllerEvents, NftControllerStateChangeEvent

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[MajorLift]

I had some questions but looks good overall! Sorry about the confusing comment order. Tried starting a review inside of vscode, and it isn't working the way I expected.

I'll take a closer look at the test files tomorrow.

[MajorLift]

I had some questions but looks good overall! Sorry about the confusing comment order. Tried starting a review inside of vscode, and it isn't working the way I expected.

I'll take a closer look at the test files tomorrow.

[MajorLift]

We'll still want to export these so they can be used inside of the package. To exclude these from package-level exports, we need to update the index.ts file so that we're explicitly enumerating all exports from NftController.ts that we want to expose externally.

Specifically, line 4:

- export * from './NftController';
+ export {
+   NftControllerMessenger, 
+   NftControllerActions, 
+   NftControllerGetStateAction,
...
+ } from './NftController';

[cryptodev-2s]

I am not sure what's being used what's not we have a lot of exports within the controller we can clean this export later ?

[MajorLift]

Everything that previously had an export keyword attached would have been package-level exports and should be added to the list.

The new exports that were added (NftControllerActions, NftControllerGetStateAction, NftControllerEvents, NftControllerStateChangeEvent) or renamed (getDefaultNftControllerState) in this PR and are intended as package-level exports need to be listed in the changelog as well.

[MajorLift]

Looks good now. Could we add a "ADDED" bullet point in the changelog section of the PR description for the new type exports? We want to log type-only changes for our packages.

[MajorLift]

@mcmire RE: #4342 (comment)

The following needs to be added to the changelog for this PR:

### Added

- Adds and exports new types: `NftControllerActions`, `NftControllerGetStateAction`, `NftControllerEvents`, `NftControllerStateChangeEvent` ([#4310](https://github.com/MetaMask/core/pull/4310)).

[MajorLift]

nit: Would it make sense to convert both the url and the query string into template strings and extract constants? This and this seem a bit more readable and reusable.

[MajorLift]

LGTM! Great job getting this done quickly even though there were a lot of details to cover.