-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssetsContractController: providerConfig -> selectedNetworkClientId #4315
Merged
mcmire
merged 8 commits into
main
from
remove-provider-config-from-assets-contract-controller
Jun 4, 2024
Merged
AssetsContractController: providerConfig -> selectedNetworkClientId #4315
mcmire
merged 8 commits into
main
from
remove-provider-config-from-assets-contract-controller
Jun 4, 2024
Commits on May 23, 2024
-
AssetsContractController: providerConfig -> selectedNetworkClientId
The `providerConfig` state property is being removed from NetworkController. Currently this property is used in AssetsContractController to get the currently selected chain, but `selectedNetworkClientId` can be used instead. This commit makes that transition so that we can fully drop `providerConfig`.
Configuration menu - View commit details
-
Copy full SHA for f004aa6 - Browse repository at this point
Copy the full SHA f004aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9310b1c - Browse repository at this point
Copy the full SHA 9310b1cView commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67ec235 - Browse repository at this point
Copy the full SHA 67ec235View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2469f0 - Browse repository at this point
Copy the full SHA b2469f0View commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 94c9359 - Browse repository at this point
Copy the full SHA 94c9359View commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cbddd6b - Browse repository at this point
Copy the full SHA cbddd6bView commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 930bd09 - Browse repository at this point
Copy the full SHA 930bd09View commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b0b4783 - Browse repository at this point
Copy the full SHA b0b4783View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.