Fully remove eth_sign

packages/controller-utils/src/constants.ts

@@ -127,7 +127,6 @@ export enum ApprovalType {
   ConnectAccounts = 'connect_accounts',
   EthDecrypt = 'eth_decrypt',
   EthGetEncryptionPublicKey = 'eth_getEncryptionPublicKey',
-  EthSign = 'eth_sign',
   EthSignTypedData = 'eth_signTypedData',
   PersonalSign = 'personal_sign',
   ResultError = 'result_error',

packages/logging-controller/src/LoggingController.test.ts

@@ -83,9 +83,9 @@ describe('LoggingController', () => {
       await unrestricted.call('LoggingController:add', {
         type: LogType.EthSignLog,
         data: {
-          signingMethod: SigningMethod.EthSign,
+          signingMethod: SigningMethod.PersonalSign,
           stage: SigningStage.Proposed,
-          signingData: '0x0000000000000',
+          signingData: 'hello',
         },
       }),
     ).toBeUndefined();
@@ -97,9 +97,9 @@ describe('LoggingController', () => {
       log: expect.objectContaining({
         type: LogType.EthSignLog,
         data: {
-          signingMethod: SigningMethod.EthSign,
+          signingMethod: SigningMethod.PersonalSign,
           stage: SigningStage.Proposed,
-          signingData: '0x0000000000000',
+          signingData: 'hello',
         },
       }),
     });
@@ -167,9 +167,9 @@ describe('LoggingController', () => {
       await unrestricted.call('LoggingController:add', {
         type: LogType.EthSignLog,
         data: {
-          signingMethod: SigningMethod.EthSign,
+          signingMethod: SigningMethod.PersonalSign,
           stage: SigningStage.Proposed,
-          signingData: '0x0000000000000',
+          signingData: 'Heya',
         },
       }),
     ).toBeUndefined();

packages/logging-controller/src/logTypes/EthSignLog.ts

@@ -4,7 +4,6 @@ import type { LogType } from './LogType';
  * An enum of the signing method types that we are interested in logging.
  */
 export enum SigningMethod {
-  EthSign = 'eth_sign',
   PersonalSign = 'personal_sign',
   EthSignTypedData = 'eth_signTypedData',
   EthSignTypedDataV3 = 'eth_signTypedData_v3',

packages/message-manager/src/AbstractMessageManager.ts

@@ -44,7 +44,7 @@ export interface AbstractMessage {
 }
 
 /**
- * @type MessageParams
+ * @type AbstractMessageParams
  *
  * Represents the parameters to pass to the signing method once the signature request is approved.
  * @property from - Address from which the message is processed

packages/message-manager/src/index.ts

@@ -1,5 +1,4 @@
 export * from './AbstractMessageManager';
-export * from './MessageManager';
 export * from './PersonalMessageManager';
 export * from './TypedMessageManager';
 export * from './EncryptionPublicKeyManager';

packages/message-manager/src/utils.ts

@@ -9,7 +9,6 @@ import { validate } from 'jsonschema';
 
 import type { DecryptMessageParams } from './DecryptMessageManager';
 import type { EncryptionPublicKeyParams } from './EncryptionPublicKeyManager';
-import type { MessageParams } from './MessageManager';
 import type { PersonalMessageParams } from './PersonalMessageManager';
 import type { TypedMessageParams } from './TypedMessageManager';
 
@@ -48,14 +47,12 @@ export function normalizeMessageData(data: string) {
 }
 
 /**
- * Validates a PersonalMessageParams and MessageParams objects for required properties and throws in
+ * Validates a PersonalMessageParams objects for required properties and throws in
  * the event of any validation error.
  *
  * @param messageData - PersonalMessageParams object to validate.
  */
-export function validateSignMessageData(
-  messageData: PersonalMessageParams | MessageParams,
-) {
+export function validateSignMessageData(messageData: PersonalMessageParams) {
   const { from, data } = messageData;
   validateAddress(from, 'from');
 

packages/network-controller/tests/provider-api-tests/shared-tests.ts

@@ -70,8 +70,6 @@ export function testsForProviderType(providerType: ProviderType) {
 
         { name: 'eth_sendRawTransaction', numberOfParameters: 1 },
         { name: 'eth_sendTransaction', numberOfParameters: 1 },
-        { name: 'eth_sign', numberOfParameters: 2 },
-
         { name: 'eth_createAccessList', numberOfParameters: 2 },
         { name: 'eth_getLogs', numberOfParameters: 1 },
         { name: 'eth_getProof', numberOfParameters: 3 },