Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 158.0.0 #4342

Merged
merged 21 commits into from
May 31, 2024
Merged

Release 158.0.0 #4342

merged 21 commits into from
May 31, 2024

Commits on May 30, 2024

  1. Release 158.0.0

    mcmire committed May 30, 2024
    Configuration menu
    Copy the full SHA
    868c871 View commit details
    Browse the repository at this point in the history
  2. Update some peer dependencies

    mcmire committed May 30, 2024
    Configuration menu
    Copy the full SHA
    012d5b9 View commit details
    Browse the repository at this point in the history
  3. Update ComposableController changelog

    Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
    mcmire and MajorLift authored May 30, 2024
    Configuration menu
    Copy the full SHA
    fc94a75 View commit details
    Browse the repository at this point in the history
  4. Update yarn.lock

    mcmire committed May 30, 2024
    Configuration menu
    Copy the full SHA
    4dd5504 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    c787fca View commit details
    Browse the repository at this point in the history
  2. Update changelogs for PR 4319

    mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cd3082d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    73d9d77 View commit details
    Browse the repository at this point in the history
  4. Update changelogs for PR 4335

    mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2064bba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c4ff489 View commit details
    Browse the repository at this point in the history
  6. Update lockfile

    mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    23ad398 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    aeb49f4 View commit details
    Browse the repository at this point in the history
  8. Remove mention of NftControllerMessenger

    Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
    mcmire and MajorLift authored May 31, 2024
    Configuration menu
    Copy the full SHA
    2d49b68 View commit details
    Browse the repository at this point in the history
  9. feat: add getSelectedMultichainAccount and listMultichainAccounts (#4330

    )
    
    ## Explanation
    
    This pull request adds two new methods `getSelectedMultichainAccount`,
    `listMultichainAccounts` and `selectedEvmAccountChange` event. The
    optional arguments are to make the changes backwards compatible when
    used with evm specific controllers.
    
    ## References
    
    Related to:
    - [381](MetaMask/accounts-planning#381)
    - [419](MetaMask/accounts-planning#419)
    
    ## Changelog
    
    ### `@metamask/accounts-controller`
    
    - **<CHANGED>**: Adds two new methods `getSelectedMultichainAccount`,
    `listMultichainAccounts`, and `selectedEvmAccountChange` event
    
    ## Checklist
    
    - [x] I've updated the test suite for new or updated code as appropriate
    - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
    updated code as appropriate
    - [x] I've highlighted breaking changes using the "BREAKING" category
    above as appropriate
    
    ---------
    
    Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
    2 people authored and mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5ab41c6 View commit details
    Browse the repository at this point in the history
  10. fix: TransactionController afterSign hook should be allowed to modify…

    … the transaction (#4343)
    
    > [!NOTE]
    > This change is intended to be cherry-picked into MetaMask/extension
    v11.17.0 via an upgrade to the @metamask/transaction-controller package.
    ## Explanation
    **Issue:**
    A recent update to the transaction-controller has made the
    TransactionMeta object passed to the `afterSign` hook frozen. This
    change prevents adding new properties, leading to the error: “Cannot add
    property custodyId, object is not extensible.” This bug is breaking all
    transactions for MMI as the original txMeta cannot store required
    properties like custodyId.
    
    **Fix:**
    We deep clone the transaction meta before passing it to the hook. A deep
    clone is used because transactionMeta is recursively frozen by immer.
    This fix was intended to minimize the change for the cherry-pick going
    into v11.17.0. A longer term solution might involve using immer more
    throughout the TransactionController.ts file to make it clearer when a
    transactionMeta is being mutated and how.
    
    **Testing:**
    This fix was applied to and verified with the MMI extension.
    
    <!--
    Thanks for your contribution! Take a moment to answer these questions so
    that reviewers have the information they need to properly understand
    your changes:
    
    * What is the current state of things and why does it need to change?
    * What is the solution your changes offer and how does it work?
    * Are there any changes whose purpose might not obvious to those
    unfamiliar with the domain?
    * If your primary goal was to update one package but you found you had
    to update another one along the way, why did you do so?
    * If you had to upgrade a dependency, why did you do so?
    -->
    
    ## References
    
    <!--
    Are there any issues that this pull request is tied to? Are there other
    links that reviewers should consult to understand these changes better?
    
    For example:
    
    * Fixes #12345
    * Related to #67890
    -->
    
    ## Changelog
    
    <!--
    If you're making any consumer-facing changes, list those changes here as
    if you were updating a changelog, using the template below as a guide.
    
    (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
    FIXED. For security-related issues, follow the Security Advisory
    process.)
    
    Please take care to name the exact pieces of the API you've added or
    changed (e.g. types, interfaces, functions, or methods).
    
    If there are any breaking changes, make sure to offer a solution for
    consumers to follow once they upgrade to the changes.
    
    Finally, if you're only making changes to development scripts or tests,
    you may replace the template below with "None".
    -->
    
    ### `@metamask/transaction-controller`
    
    - **FIXED**: afterSign hook is now able to modify the transaction
    
    ## Checklist
    
    - [ ] I've updated the test suite for new or updated code as appropriate
    - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
    updated code as appropriate
    - [ ] I've highlighted breaking changes using the "BREAKING" category
    above as appropriate
    dbrans authored and mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7e117ac View commit details
    Browse the repository at this point in the history
  11. exclude fields from token list fetch (#4235)

    ## Explanation
    
    Adds 2 query parameters when fetching token lists:
    - `includeERC20Permit=false`
    - `includeStorage=false`
    
    The best I can tell, neither field is used by extension or mobile. So
    we'll instead take the reduction in network usage (~5KB on mainnet) and
    controller state.
    
    ## References
    
    https://consensyssoftware.atlassian.net/browse/API-1186
    
    ## Changelog
    
    ### `@metamask/assets-controllers`
    
    - **BREAKING**: `TokenListController` no longer includes the fields
    `storage` and `erc20Permit` in its state.
    
    ## Checklist
    
    - [ ] I've updated the test suite for new or updated code as appropriate
    - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
    updated code as appropriate
    - [ ] I've highlighted breaking changes using the "BREAKING" category
    above as appropriate
    bergeron authored and mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    18b9b62 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d28191e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2780b47 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f96fead View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2b9b0a4 View commit details
    Browse the repository at this point in the history
  16. Fix lint violation

    mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4856c6c View commit details
    Browse the repository at this point in the history
  17. Mark PR 4235 as breaking

    mcmire committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f45ee7f View commit details
    Browse the repository at this point in the history