Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assets-controllers: Remove AllowedActions, AllowedEvents #4344

Merged
merged 2 commits into from
May 31, 2024
Merged

assets-controllers: Remove AllowedActions, AllowedEvents #4344

merged 2 commits into from
May 31, 2024

Commits on May 30, 2024

  1. assets-controllers: Remove AllowedActions, AllowedEvents 

    These types were mistakenly exported in a previous commit when
converting NftDetectionController to BaseController v2. They can still
be exports in `NftDetectionController.ts`, but just not be exports from
the perspective of the whole `assets-controllers` package. This commit
takes these exports away by replacing the `*` export in `index.ts` with
explicit names and ensures not to include the two aforementioned types.
    @mcmire
    mcmire committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e35faca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into remove-allowed-events-and-actions-for-nft-de… 

    …tection-controller
    @mcmire
    mcmire authored May 30, 2024
    Configuration menu
    Copy the full SHA
    ae3b7b9 View commit details
    Browse the repository at this point in the history