feat: remove global network from signature controller #4797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Remove all global network usage form the signature controller to support multi-chain in the clients.
Specifically:
getCurrentChainId
constructor callback fromSignatureController
.chainId
usingnetworkClientId
fromrequest
argument andNetworkController
messenger action.chainId
andnetworkClientId
in state.References
Fixes #3498
Changelog
@metamask/signature-controller
chainId
andnetworkClientId
toSignatureRequest
andLegacyMessage
types.networkClientId
provided or ifchainId
cannot be determined.getCurrentChainId
callback from constructor options.Checklist